Re: CONFIG_HIGHPTE vs. sub-page page tables.

From: Ingo Molnar
Date: Fri Feb 08 2008 - 18:15:31 EST



* Ingo Molnar <mingo@xxxxxxx> wrote:

> config attached. It seems all !PAE 32-bit kernel builds are broken due
> to this. The patch below fixes it.

ok, the patch was against x86.git which had some other changes in this
area - the one below applies to vanilla -git and fixes the bug.

Ingo

----------------->
Subject: x86: fix pgtable_t build breakage
From: Ingo Molnar <mingo@xxxxxxx>

fix build breakage caused by commit 2f569afd9ced9ebec9.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
include/asm-x86/page_32.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Index: linux-x86.q/include/asm-x86/page_32.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/page_32.h
+++ linux-x86.q/include/asm-x86/page_32.h
@@ -50,11 +50,13 @@ typedef unsigned long phys_addr_t;
typedef union { pteval_t pte, pte_low; } pte_t;
typedef pte_t boot_pte_t;

-typedef struct page *pgtable_t;
-
#endif /* __ASSEMBLY__ */
#endif /* CONFIG_X86_PAE */

+#ifndef __ASSEMBLY__
+typedef struct page *pgtable_t;
+#endif
+
#ifdef CONFIG_HUGETLB_PAGE
#define HAVE_ARCH_HUGETLB_UNMAPPED_AREA
#endif
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/