Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

[James Bottomley]

On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> +       if (hdr->id == id_nic) {
> +               pci_dev = pci_get_bus_and_slot((nic->pci_bdf & 0xff00) >> 8,
> +                                              (nic->pci_bdf & 0xff));
> +               if (pci_dev) {
> +                       rc = sysfs_create_link(&ibft_kobj->kobj,
> +                                              &pci_dev->dev.kobj, "device");
> +                       pci_dev_put(pci_dev);
> +               }

pci_get_bus_and_slot fails in the presence of PCI domains, which are
getting to be fairly common even in medium sized servers ... what
happens in that case?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/