Re: [PATCH] Replace nvidia timer override quirk with pci id list
From: Thomas Gleixner
Date: Sat Feb 09 2008 - 06:07:19 EST
On Sat, 9 Feb 2008, Prakash Punnoor wrote:
> On the day of Friday 08 February 2008 Andi Kleen hast written:
> > On Fri, Feb 08, 2008 at 08:00:39PM +0100, Prakash Punnoor wrote:
> > > On the day of Friday 08 February 2008 Andi Kleen hast written:
> > > > On Fri, Feb 08, 2008 at 06:39:17PM +0100, Prakash Punnoor wrote:
> > > > >
> > > > > Yes, confirmed. timer w/o the skipping stays XT-PIC on nforce2.
> > > >
> > > > Confirmed what? Did you test my patch on both machines?
> > > > What was the result?
> > >
> > > I confirmed that it (nforce2) needed the acpi_skip_timer_override. If you
> > > read my mail, you knew I didn't test your patch.
> >
> > Ok can you please do so then? Or stop your obstructism?
>
> Grr, I don't know why I am discussing with stubborn and/or arrogant devs like
> you seem to be. But I actually did what you wanted and as *expected* - as I
> said I understand that trivial piece of code you posted - your patch fails
> here for my nforce2:
No worry, this patch wont go anywhere near mainline as long as it
breaks stuff and obviously you are under no obligation to re-test
patches that have not been changed just re-submitted.
x86 changes, which are considered for mainline are staged in the mm
branch of the x86 git tree:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=shortlog;h=mm
Instructions for checking it out are here:
http://people.redhat.com/mingo/x86.git/README
Please let us know, if there is anything which breaks your box(en).
Thanks for your feedback and patience.
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/