Re: [RFC] Sectionized printk data

[Jan Engelhardt]

On Feb 4 2008 19:07, Sam Ravnborg wrote:
>> The attached patch allows something along the lines:
>> 
>> int __init some_function(void)
>> {
>>         [...]
>>         pr_init(KERN_WARNING "failure %s in %s\n", ...);
>>         [...]
>> }
>> 
>> Another idea I had was to make printk a macro that figures out the
>> section of the surrounding function and then moves the data
>> automatically when it is a literal, but I couldn't find mechanisms that
>> allow this.  Anyone of you got an idea?
>> 
>> What do you think in general?
>
>What is the rationale behind this?

To drop strings that are only shown once anyway, such as:

static int __init ebtables_init(void)
{
        int ret;

        mutex_lock(&ebt_mutex);
        list_add(&ebt_standard_target.list, &ebt_targets);
        mutex_unlock(&ebt_mutex);
        if ((ret = nf_register_sockopt(&ebt_sockopts)) < 0)
                return ret;

->      printk(KERN_INFO "Ebtables v2.0 registered\n");
        return 0;
}

>If you say "saving memory" then please let us know with specific examples
>in what area these savings will really pay off.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/