Re: [5/6] x86: kgdb support

[Sam Ravnborg]

On Sun, Feb 10, 2008 at 08:13:45AM +0100, Ingo Molnar wrote:
> From: Ingo Molnar <mingo@xxxxxxx>
> 
> simplified and streamlined kgdb support on x86, both 32-bit and 64-bit,
> based on patch from:
> 
>   Subject: kgdb: core-lite
>   From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
> 
> [ and countless other authors - see the patch for details. ]
> 
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  arch/x86/Kconfig         |    4 
>  arch/x86/kernel/Makefile |    1 
>  arch/x86/kernel/kgdb.c   |  550 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/asm-x86/kgdb.h   |   87 +++++++
>  4 files changed, 642 insertions(+)
> 
> Index: linux-kgdb.q/arch/x86/Kconfig
> ===================================================================
> --- linux-kgdb.q.orig/arch/x86/Kconfig
> +++ linux-kgdb.q/arch/x86/Kconfig
> @@ -14,6 +14,7 @@ config X86_32
>  
>  config X86_64
>  	def_bool 64BIT
> +	select KGDB_ARCH_HAS_SHADOW_INFO
>  
>  ### Arch settings
>  config X86
> @@ -139,6 +140,9 @@ config AUDIT_ARCH
>  config ARCH_SUPPORTS_AOUT
>  	def_bool y
>  
> +config ARCH_SUPPORTS_KGDB
> +	def_bool y
> +

Please use the documented HAVE_ approach and not this
ugly "one variable per arch" idiom.
This was also commented last time the patchset were posted.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/