Re: [git pull] kgdb light, v5

From: Ingo Molnar
Date: Sun Feb 10 2008 - 14:38:48 EST



* Jan Kiszka <jan.kiszka@xxxxxx> wrote:

> [This still runs fine here, but sharp eyes are always welcome!]
>
> Cleanup of the way kgdb
> - accesses unsafe memory via probe_kernel_*
> - converts to/from hex representation
> - passes errors due to such accesses around
>
> At this chance I also fix kgdb_ebin2mem, which was broken /wrt escape
> sequence handling.

great! Applied. The kgdb memory accesses look _much_ cleaner now, and
it's a significant simplification as well:

2 files changed, 109 insertions(+), 244 deletions(-)

the uaccess.h macros look a bit ugly now (it all got inherited from the
existing [and ancient] probe_kernel_address() macro) and because we now
touch it materially anyway, we might as well do it right?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/