Re: [PATCH 8/8] : Use FIELD_SIZEOF

From: Alexey Dobriyan
Date: Sun Feb 10 2008 - 16:13:20 EST


On Sun, Feb 10, 2008 at 09:16:04PM +0100, Julia Lawall wrote:
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -618,7 +618,7 @@ static inline int param_type2af(__be16 t
> static inline int sctp_sanity_check(void)
> {
> SCTP_ASSERT(sizeof(struct sctp_ulpevent) <=
> - sizeof(((struct sk_buff *)0)->cb),
> + FIELD_SIZEOF(struct sk_buff, cb),
> "SCTP: ulpevent does not fit in skb!\n", return 0);
>
> return 1;

Same here. Use BUILD_BUG_ON instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/