Re: [PATCH] dmi: Prevent linked list corruption (resent)

[Parag Warudkar]

On Feb 11, 2008 12:24 PM, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> [Once more without forgetting the last "quilt refresh", sorry.]
>
> Adding the same item to a given linked list more than once is guaranteed
> to break and corrupt the list. This is however what we do in dmi_scan
> since commit 79da4721117fcf188b4b007b775738a530f574da.
>
> Given that there is absolutely no interest in saving empty OEM
> strings anyway, I propose the simple and efficient fix below: we
> discard the empty OEM strings altogether.
>
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Parag Warudkar <parag.warudkar@xxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

I suppose the list would be corrupted only if there are deletions from
the list? (Which there aren't.)

Anyway not adding the empty strings is way better and I don't see now
how they could've been useful.
(I added them out of the doubt of breaking something.)

Acked-By: Parag Warudkar <parag.warudkar@xxxxxxxxx>

Thanks

Parag
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/