Re: [10/19] ftrace: add basic support for gcc profiler instrumentation

[Steven Rostedt]

On Sun, 10 Feb 2008, Jan Engelhardt wrote:

>
> On Feb 10 2008 08:20, Ingo Molnar wrote:
> >--- linux.orig/Makefile
> >+++ linux/Makefile
> >@@ -509,6 +509,9 @@ endif
> >
> > include $(srctree)/arch/$(SRCARCH)/Makefile
> >
> >+ifdef CONFIG_FTRACE
> >+KBUILD_CFLAGS	+= -pg
> >+endif
> > ifdef CONFIG_FRAME_POINTER
> > KBUILD_CFLAGS	+= -fno-omit-frame-pointer -fno-optimize-sibling-calls
> > else
>
> You should use -fno-omit-frame-pointer when building with -pg; As far
> as I can remember from using gprof in the past (in userspace, I might
> add), the output does not make much sense without frame boundaries.
>

It is, but is hidden in the Kconfig. I moved it to Kconfig as it was
recommended to me because it is cleaner to do it there.

Two patches later:

+config FTRACE
+       bool "Kernel Function Tracer"
+       depends on DEBUG_KERNEL && HAVE_FTRACE
+       select FRAME_POINTER


-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/