Re: [PATCH 4/4] x86_64: check msr to get mmconfig for amd family10h opteron v3

[Andrew Morton]

On Mon, 11 Feb 2008 18:20:46 -0800 Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:

> On Monday 11 February 2008 05:09:44 pm Andrew Morton wrote:
> > On Mon, 11 Feb 2008 16:48:35 -0800
> > Yinghai Lu <Yinghai.Lu@xxxxxxx> wrote:
> > 
> > > From: Yinghai Lu <Yinghai.Lu@xxxxxxx>
> > > 
> > > so even booting kernel with acpi=off or even MCFG is not there, we still can
> > > use MMCONFIG.
> > > 
> > 
> > This patch threw a big reject.  I didn't check why.
> > 
> > 
> > > +		pci_direct_conf1.read(0, bus, devfn, 0, 4, &l);
> > 
> > When I fixed the reject, compilation failed here.
> > 
> > arch/x86/pci/mmconfig-shared.c: In function 'pci_mmcfg_check_hostbridge':
> > arch/x86/pci/mmconfig-shared.c:214: error: 'pci_direct_conf1' undeclared (first use in this function)
> > 
> > 
> > What kernel are you patching?
> > 
> 
> linus tree. 

hm.  So why didn't it compile?  pci_direct_conf1 is defined over in
arch/x86/pci/direct.c and is not mentioned in any header file.

> other three are ok?

Well, they applied, but I didn't review, build-test or merge them.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/