Re: [PATCH] hwmon: (adm1026) Properly terminate sysfs groups (Was: panic about sysfs with adm1026)

[Jean Delvare]

On Tue, 12 Feb 2008 07:27:15 -0800, Greg KH wrote:
> On Tue, Feb 12, 2008 at 09:27:22AM +0100, Jean Delvare wrote:
> > Hi Yinghai,
> > 
> > On Mon, 11 Feb 2008 15:39:39 -0800, Yinghai Lu wrote:
> > > On Feb 10, 2008 10:01 AM, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> > > > Yeah, I am an idiot. In 5b34dbcd88251508d02e48ad9b0f9b8232a13ee0 I
> > > > introduced two new sysfs file groups but forgot to NULL-terminate them.
> > > > Sorry about that, here's the fix:
> > > >
> > > > * * * * *
> > > >
> > > > The missing NULL at the end of two sysfs file groups causes a kernel
> > > > crash when calling sysfs_create_group().
> > > >
> > > > Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> > > > ---
> > > >  drivers/hwmon/adm1026.c |    2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > --- linux-2.6.25-rc0.orig/drivers/hwmon/adm1026.c       2008-02-10 11:21:54.000000000 +0100
> > > > +++ linux-2.6.25-rc0/drivers/hwmon/adm1026.c    2008-02-10 18:51:00.000000000 +0100
> > > > @@ -1624,6 +1624,7 @@ static struct attribute *adm1026_attribu
> > > >         &dev_attr_temp3_crit_enable.attr,
> > > >         &dev_attr_temp3_auto_point1_pwm.attr,
> > > >         &dev_attr_temp3_auto_point2_pwm.attr,
> > > > +       NULL
> > > >  };
> > > >
> > > >  static const struct attribute_group adm1026_group_temp3 = {
> > > > @@ -1639,6 +1640,7 @@ static struct attribute *adm1026_attribu
> > > >         &sensor_dev_attr_in9_max.dev_attr.attr,
> > > >         &sensor_dev_attr_in9_min.dev_attr.attr,
> > > >         &sensor_dev_attr_in9_alarm.dev_attr.attr,
> > > > +       NULL
> > > >  };
> > > >
> > > >  static const struct attribute_group adm1026_group_in8_9 = {
> > > >
> > > > * * * * *
> > > 
> > > it works. Thanks
> > 
> > Great, thanks. Mark, please include this patch in your next patch to
> > Linus for 2.6.25.
> 
> Can someone send it to stable@xxxxxxxxxx also when it goes into Linus's
> tree, as it looks like a pretty bad thing :)

I certainly could, but then you would laugh at me because 2.6.24 isn't
affected by the bug.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/