Re: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32users

[Olof Johansson]

Hi,

On Tue, Feb 12, 2008 at 05:43:56PM +0100, Haavard Skinnemoen wrote:
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@xxxxxxxxx>
> ---
>  drivers/dma/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 893a3f8..1a727c1 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig DMADEVICES
>  	bool "DMA Engine support"
> -	depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> +	depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || AVR32

This is a slippery slope. Things should be the other way around instead,
create a HAVE_DMA_DEVICE, select it in the relevant platform code and
make DMADEVICES depend on that.

Or just let the subsystem always be available.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/