Re: [PATCH v2] Execute tasklets in the same order they were queued

From: Andrew Morton
Date: Tue Feb 12 2008 - 17:20:29 EST


On Tue, 12 Feb 2008 16:06:47 -0600
Olof Johansson <olof@xxxxxxxxx> wrote:

> I noticed this when looking at an openswan issue. Openswan (ab?)uses
> the tasklet API to defer processing of packets in some situations,
> with one packet per tasklet_action(). I started noticing sequences
> of backwards-ordered sequence numbers coming over the wire, since
> new tasklets are always queued at the head of the list but processed
> sequentially.
>
> Convert it to instead append new entries to the tail of the list. As an
> extra bonus, the splicing code in takeover_tasklets() no longer has to
> iterate over the list.

hm, well, let's see what if any effect this has on networking.

I'll cheerily tag this as to-be-merged-via-git-sched. Ingo wasn't doing
much anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/