Re: [PATCH 1/1] NBD: make nbd default to deadline I/O scheduler

[Andrew Morton]

On Sat, 09 Feb 2008 08:30:40 -0500
Paul Clements <paul.clements@xxxxxxxxxxxx> wrote:

> +		old_e = disk->queue->elevator;
> +		if (elevator_init(disk->queue, "deadline") == 0 ||
> +			elevator_init(disk->queue, "noop") == 0) {
> +				elevator_exit(old_e);
> +		}
>  	}

afacit elevator_init() will not trigger a request_module().  And you really
do want to trigger the request_module() here.  Perhaps the block layer
should provide a means of doing so?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/