Re: [PATCH] pata_cs5536 Fix secondary port configuration

[Martin K. Petersen]

>>>>> "Gregor" == Gregor Radtke <mail@xxxxxxxxxxxxx> writes:

Gregor> boots! 

Excellent.  Thanks for testing this!  I have sent the patch upstream.


Gregor> Anyway, the patch fits perfectly and now UDMA/33 (due to
Gregor> 40wire-cable, vendor says UDMA/100 should work either) on a
Gregor> HDD using pata_cs5536 just works =)

pata_amd.c happens to ignore the 40/80 wire configuration bit on
CS5536 and a couple of other chips.  That's why it negotiates
UDMA/100 regardless of cable type.

pata_cs5536.c relies on the BIOS telling it whether an 80-wire cable
is connected or not.

I have attached a patch that dumps the 5536 IDE configuration
registers during boot. If you like you can apply that and mail me the
resulting register dump.  That'll tell us how your BIOS initialized
the chip.

-- 
Martin K. Petersen	Oracle Linux Engineering


diff -r b0dc16d276be drivers/ata/pata_cs5536.c
--- a/drivers/ata/pata_cs5536.c	Tue Feb 12 08:52:44 2008 -0500
+++ b/drivers/ata/pata_cs5536.c	Wed Feb 13 01:51:00 2008 -0500
@@ -73,6 +73,11 @@ enum {
 	IDE_CAST_CMD_SHIFT	= 24,
 
 	IDE_ETC_NODMA		= 0x03,
+
+	CFG_REG_MASK		= 0x34002,
+	DTC_REG_MASK		= 0xffff0000,
+	CAST_REG_MASK		= 0xff0000f0,
+	ETC_REG_MASK		= 0xc7c70000,
 };
 
 static int use_msr;
@@ -84,6 +89,23 @@ static const u8 pci_reg[4] = {
 static const u8 pci_reg[4] = {
 	PCI_IDE_CFG, PCI_IDE_DTC, PCI_IDE_CAST, PCI_IDE_ETC,
 };
+
+static void cs5536_regs(void)
+{
+        u32 reg, dummy;
+
+        rdmsr(MSR_IDE_CFG, reg, dummy);
+        printk(KERN_ERR " CFG  = 0x%08x\n", reg & CFG_REG_MASK);
+
+        rdmsr(MSR_IDE_DTC, reg, dummy);
+        printk(KERN_ERR " DTC  = 0x%08x\n", reg & DTC_REG_MASK);
+
+        rdmsr(MSR_IDE_CAST, reg, dummy);
+        printk(KERN_ERR " CAST = 0x%08x\n", reg & CAST_REG_MASK);
+
+        rdmsr(MSR_IDE_ETC, reg, dummy);
+        printk(KERN_ERR " ETC  = 0x%08x\n", reg & ETC_REG_MASK);
+}
 
 static inline int cs5536_read(struct pci_dev *pdev, int reg, int *val)
 {
@@ -303,6 +325,8 @@ static int cs5536_init_one(struct pci_de
 		return -ENODEV;
 	}
 
+	cs5536_regs();
+
 	return ata_pci_init_one(dev, ppi);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/