Re: [PATCH] [1/2] CPA: Fix set_memory_x for ioremap v2

From: Andi Kleen
Date: Wed Feb 13 2008 - 06:26:36 EST




> The so-called "significant restructuring" took a mere 2 hours,
> which is probably less than the time consumed in this thread.

Hmm, it doesn't do what I meant and I don't think you solved
the problem. You still check against the vaddrs
which won't work for ioremaps or fixmap (and thus not
fix the EFI cases)

What I meant with restructuring is calling lookup_address() early,
get the physical address from the PTE, then check that against
the alias ranges in physical. That would actually work for fixmaps
and ioremaps and all other mappings too.

I'm sure it can be all done, but for me it to submit such
a change would likely require weeks of thread like this so
I'm not trying.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/