Re: [PATCH] x86: include prototype for no_broadcast inmach-default/setup.c

[Harvey Harrison]

On Wed, 2008-02-13 at 11:42 +0100, Ingo Molnar wrote:
> * Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:
> 
> > Fixes sparse warning:
> > arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static?
> 
> hm, this patch causes a build failure:
> 
> In file included from arch/x86/mach-default/setup.c:13:
> include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_allbutself':
> include/asm/mach-default/mach_ipi.h:25: error: 'APIC_DEST_ALLBUT' undeclared (first use in this function)
> include/asm/mach-default/mach_ipi.h:25: error: (Each undeclared identifier is reported only once
> include/asm/mach-default/mach_ipi.h:25: error: for each function it appears in.)include/asm/mach-default/mach_ipi.h: In function '__local_send_IPI_all':
> include/asm/mach-default/mach_ipi.h:33: error: 'APIC_DEST_ALLINC' undeclared (first use in this function)
> 
> config attached. The include file dependencies in this area are a bit of 
> a mess - perhaps they need some cleanups?

OK, I'm building all(yes|mod)configs and didn't see this.  Agreed about
the file dependencies here, I'll take a look.  If you have any notes
lying around, would appreciate the head-start.


Harvey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/