Re: [PATCH 4/8] IPMI: Don't grab locks in run-to-completion mode

[Andrew Morton]

On Wed, 13 Feb 2008 10:27:49 -0600
Corey Minyard <minyard@xxxxxxx> wrote:

> This patch prevents deadlocks in IPMI panic handler caused by msg_lock
> in smi_info structure and waiting_msgs_lock in ipmi_smi structure.

Again, what are the newly-added barrier()s for?  Was cpu_relax()
intended?

If a barrier indeed was intended then, as always, each one should have
a comment explaining why it is there.  Because it is frequently hard to
determine what the programmer was trying to do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/