Re: [PATCH 3/8] IPMI: Run to completion fixes

[Corey Minyard]

Andrew Morton wrote:
> On Wed, 13 Feb 2008 10:23:42 -0600
> Corey Minyard <minyard@xxxxxxx> wrote:
>
>   
> > From: Corey Minyard <cminyard@xxxxxxxxxx>
> >
> > The "run_to_completion" mode was somewhat broken.  Locks need to be
> > avoided in run_to_completion mode, and it shouldn't be used by normal
> > users, just internally for panic situations.
> >
> > This patch removes locks in run_to_completion mode and removes the
> > user call for setting the mode.  The only user was the poweroff
> > code, but it was easily converted to use the polling interface.
> >
> > +	/*
> > +	 * Spin until our message is done.
> > +	 */
> > +	while (atomic_read(&dummy_count) > 0) {
> > +		ipmi_poll_interface(user);
> > +		barrier();
> > +	}
> >     
>
> we'd normally use cpu_relax() here.
>   
Yes, that's what I should have used.  I'll submit a new patch to fix this.

-corey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/