Re: [PATCH] Fix direct mapping alias regressin in ioremap v2

[Ingo Molnar]

* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

>     Fix bug noticed by Ingo of __va() wrapping on 32bit

what you should realize is that had we applied your previous patch in a 
rush, it would have introduced a far more serious regression than the 
type of problem you are trying to solve. That's one of the reasons why 
we disagree with your sense of urgency.

We've got the clean fixes queued up and it's all under testing. (going 
fine so far)

Also, you only appear to have resent your fix with the obvious bug 
fixed, but it's still unclean and you do not seem to have replied to my 
main structural argument:

> > Please have a look at how we solved the "secondary alias" 64-bit 
> > problem in x86.git#mm and please resend against x86.git#mm if you 
> > still think something is missing. Thanks,

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/