Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

From: Alan Cox
Date: Thu Feb 14 2008 - 13:04:09 EST


On Thu, 14 Feb 2008 09:36:32 -0800
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> Use ld_qdi and ld_winbond to avoid shadowing static int
> variables qdi and winbond. The ld_ prefix refers to
> legacy_data.
>
> drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:848:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:882:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one
> drivers/ata/pata_legacy.c:129:12: originally declared here
>
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/