[patch 1/6] Generic thermal management: validate input parameters

From: Thomas, Sujith
Date: Fri Feb 15 2008 - 00:25:58 EST


From: Thomas Sujith <sujith.thomas@xxxxxxxxx>

Added sanity check to make sure that thermal zone
and cooling device exists.

Signed-off-by: Thomas Sujith <sujith.thomas@xxxxxxxxx>
---

drivers/thermal/thermal.c | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletion(-)

Index: linux-2.6.24/drivers/thermal/thermal.c
===================================================================
--- linux-2.6.24.orig/drivers/thermal/thermal.c
+++ linux-2.6.24/drivers/thermal/thermal.c
@@ -306,12 +306,23 @@ int thermal_zone_bind_cooling_device(str
{
struct thermal_cooling_device_instance *dev;
struct thermal_cooling_device_instance *pos;
+ struct thermal_zone_device *pos1;
+ struct thermal_cooling_device *pos2;
int result;

if (trip >= tz->trips || (trip < 0 && trip !=
THERMAL_TRIPS_NONE))
return -EINVAL;

- if (!tz || !cdev)
+ list_for_each_entry(pos1, &thermal_tz_list, node) {
+ if (pos1 == tz)
+ break;
+ }
+ list_for_each_entry(pos2, &thermal_cdev_list, node) {
+ if (pos2 == cdev)
+ break;
+ }
+
+ if (tz != pos1 || cdev != pos2)
return -EINVAL;

dev =

Attachment: [patch 1 of 6] Thermal Management - validate input parameters
Description: [patch 1 of 6] Thermal Management - validate input parameters