Re: [PATCH] gdth: convert to PCI hotplug API

[Jeff Garzik]

James Bottomley wrote:
> > diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
> > index c825239..1b53e92 100644
> > --- a/drivers/scsi/gdth.c
> > +++ b/drivers/scsi/gdth.c
> > @@ -595,85 +595,107 @@ static int __init gdth_search_isa(ulong32 bios_adr)
> >  #endif /* CONFIG_ISA */
> >  
> >  #ifdef CONFIG_PCI
> > -static void gdth_search_dev(gdth_pci_str *pcistr, ushort *cnt,
> > -                            ushort vendor, ushort dev);
> > +static gdth_pci_str gdth_pcistr[MAXHA];
> > +static int gdth_pci_cnt;
> > +static bool gdth_pci_registered;
>
> Could we get rid of these static arrays and MAXHA entirely?  It should
> be possible just to bung the parameters in pci_str into gdth_ha_str and
> dump the arrays.


I kept those array for one reason:  you need it to preserve the existing 
in-driver PCI device sort.

If we can eliminate the sorting, then the array can easily disappear.

I /think/ the sort can be eliminated now because we have pci=reverse, 
but I have not verified that guess.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/