[RFC-PATCH] fuse: shadowed variable warning

From: Harvey Harrison
Date: Fri Feb 15 2008 - 13:59:00 EST


fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one
fs/fuse/dir.c:893:6: originally declared here

This means that an error between lines 909 and 923 will not be
returned.

Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
---
Miklos, could you confirm whether or not you want the err from lines
909-923 returned or not. If so, I can respin this patch changing the
variable name instead which would preserve the current behavior.
This patch changes behavior.

fs/fuse/dir.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 7fb514b..c4807b3 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -906,7 +906,7 @@ static int fuse_permission(struct inode *inode, int mask, struct nameidata *nd)
}

if (fc->flags & FUSE_DEFAULT_PERMISSIONS) {
- int err = generic_permission(inode, mask, NULL);
+ err = generic_permission(inode, mask, NULL);

/* If permission is denied, try to refresh file
attributes. This is also needed, because the root
--
1.5.4.1.1278.gc75be



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/