Re: [PATCH] befs: fix sparse warning in linuxvfs.c

[Andrew Morton]

On Fri, 15 Feb 2008 10:46:04 -0800
Harvey Harrison <harvey.harrison@xxxxxxxxx> wrote:

> Use link as the variable name to avoid shadowing the arg.
> 
> fs/befs/linuxvfs.c:492:8: warning: symbol 'p' shadows an earlier one
> fs/befs/linuxvfs.c:488:77: originally declared here
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> ---
> This should be checked in case there is a latent bug here.  Should it
> be the arg *p getting freed, or the local var *p that was shadowing
> it?
> 

The code looks OK - the name was allocated in befs_follow_link() and was
saved away with nd_set_link().

> 
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index 82123ff..e8717de 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -489,9 +489,9 @@ static void befs_put_link(struct dentry *dentry, struct nameidata *nd, void *p)
>  {
>  	befs_inode_info *befs_ino = BEFS_I(dentry->d_inode);
>  	if (befs_ino->i_flags & BEFS_LONG_SYMLINK) {
> -		char *p = nd_get_link(nd);
> -		if (!IS_ERR(p))
> -			kfree(p);
> +		char *link = nd_get_link(nd);
> +		if (!IS_ERR(link))
> +			kfree(link);
>  	}
>  }
>  
> -- 
> 1.5.4.1.1278.gc75be
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/