Re: [patch 07/13] Initialize per cpu lowcores on cpu hotplug.

[Bastian Blank]

On Wed, Feb 20, 2008 at 10:45:52AM +0100, Heiko Carstens wrote:
> -	copy_page(lowcore, &S390_lowcore);
> +	memcpy(lowcore, &S390_lowcore, 512);

Okay

>  	memset((void *)lowcore + 512, 0, sizeof(*lowcore) - 512);

Not completely okay. void pointer are not allowed in arithmetic. gcc
handles void * as char * in this case, but I think it should usualy be
avoided.

Bastian

-- 
Peace was the way.
		-- Kirk, "The City on the Edge of Forever", stardate unknown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/