Re: tty && pid problems

[Jiri Slaby]

On 02/20/2008 05:28 PM, Oleg Nesterov wrote:
> I think you can revert the tty-bkl-pushdown.patch. Or, as Eric suggested, just
> revert this
>
> 	@@ -1222,7 +1221,7 @@ static const struct file_operations tty_
> 		.read           = tty_read,
> 		.write          = tty_write,
> 		.poll           = tty_poll,
> 	-       .ioctl          = tty_ioctl,
> 	+       .unlocked_ioctl = tty_ioctl,
> 		.compat_ioctl   = tty_compat_ioctl,
> 		.open           = tty_open,
> 		.release        = tty_release,
> 	@@ -1235,7 +1234,7 @@ static const struct file_operations ptmx
> 		.read           = tty_read,
> 		.write          = tty_write,
> 		.poll           = tty_poll,
> 	-       .ioctl          = tty_ioctl,
> 	+       .unlocked_ioctl = tty_ioctl,
> 		.compat_ioctl   = tty_compat_ioctl,
> 		.open           = ptmx_open,
> 		.release        = tty_release,
> 	@@ -1248,7 +1247,7 @@ static const struct file_operations cons
> 		.read           = tty_read,
> 		.write          = redirected_tty_write,
> 		.poll           = tty_poll,
> 	-       .ioctl          = tty_ioctl,
> 	+       .unlocked_ioctl = tty_ioctl,
> 		.compat_ioctl   = tty_compat_ioctl,
> 		.open           = tty_open,
> 		.release        = tty_release,
> 	@@ -1260,7 +1259,7 @@ static const struct file_operations hung
> 		.read           = hung_up_tty_read,
> 		.write          = hung_up_tty_write,
> 		.poll           = hung_up_tty_poll,
> 	-       .ioctl          = hung_up_tty_ioctl,
> 	+       .unlocked_ioctl = hung_up_tty_ioctl,
> 		.compat_ioctl   = hung_up_tty_compat_ioctl,
> 		.release        = tty_release,
> 	 };
>
> chunk.

This would result in unpredictable behaviour. If I left locking apart, ioctl 
prototype != unlocked_ioctl prototype.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/