Re: [PATCH] viocons: BKL locking

From: Paul Mackerras
Date: Wed Feb 20 2008 - 22:58:47 EST


Alan Cox writes:

> For some weird reason I can't ascertain (translation "I think its
> broken") the viocons driver calls directly into the n_tty ldisc code even
> if another ldisc is in use. It'll probably break if you do that but I'm
> just fixing the locking and adding a comment that its horked.

Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
of calling n_tty_ioctl -- do you agree?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/