Re: [RFC] mmiotrace full patch, preview 1

[Sam Ravnborg]

Hi Pekka.

A small nitpick..
>  
> +config MMIOTRACE_HOOKS
> +	bool
> +	default n
n is default so no need to be explicit.
If you prefer being explcit then use:

	def_bool n

> +config MMIOTRACE
> +	tristate "Memory mapped IO tracing"
> +	depends on DEBUG_KERNEL && RELAY && DEBUG_FS
> +	select MMIOTRACE_HOOKS
> +	default n
Same here.


> +	help
> +	  This will build a kernel module called mmiotrace.
> +	  Making this a built-in is heavily discouraged.
> +
> +	  Mmiotrace traces Memory Mapped I/O access and is meant for debugging
> +	  and reverse engineering. The kernel module offers wrapped
> +	  versions of the ioremap family of functions. The driver to be traced
> +	  must be modified to call these wrappers. A user space program is
> +	  required to collect the MMIO data.
> +
> +	  See http://nouveau.freedesktop.org/wiki/MmioTrace
> +	  If you are not helping to develop drivers, say N.
> +
> +config MMIOTRACE_TEST
> +	tristate "Test module for mmiotrace"
> +	depends on MMIOTRACE && m
> +	default n
> +	help
> +	  This is a dumb module for testing mmiotrace. It is very dangerous
> +	  as it will write garbage to IO memory starting at a given address.
> +	  However, it should be safe to use on e.g. unused portion of VRAM.
> +
> +	  Say N, unless you absolutely know what you are doing.
> +
>  #
>  # IO delay types:
>  #
> diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
> index 9832910..e182f6d 100644
> --- a/arch/x86/mm/Makefile
> +++ b/arch/x86/mm/Makefile
> @@ -3,3 +3,8 @@ include ${srctree}/arch/x86/mm/Makefile_32
>  else
>  include ${srctree}/arch/x86/mm/Makefile_64
>  endif
> +
> +obj-$(CONFIG_MMIOTRACE_HOOKS)	+= kmmio.o
> +obj-$(CONFIG_MMIOTRACE) 	+= mmiotrace.o
> +mmiotrace-objs			:= pf_in.o mmio-mod.o

Do not use '-objs' - '-y' is preferred as below:
> +mmiotrace-y				:= pf_in.o mmio-mod.o


	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/