Re: [PATCH] x86_64: make amd quad core 8 socket system not beclustered_box v2

[Yinghai Lu]

On Sunday 24 February 2008 04:29:03 am Andi Kleen wrote:
> On Sat, Feb 23, 2008 at 09:48:42PM -0800, Yinghai Lu wrote:
> > 
> > quad core 8 socket system will have apic id lifting.the apic id range could
> > be [4, 0x23]. and apic_is_clustered_box will think that need to three clusters
> > and that is large than 2. So it is treated as clustered_box.
> 
> Ok I see you chose the quick hack over doing it properly ...
> 
> > 
> > and will get
> > 
> > Marking TSC unstable due to TSCs unsynchronized
> > 
> > even the CPUs have X86_FEATURE_CONSTANT_TSC set.
> 
> I doubt that will do the right thing on AMD based vSMP,
> which also required the cluster check on AMD iirc.
> 
> Cc'ed Kiran/Shai. damage has already hit x86 tree I believe.

do you have bootlog for these box?

IBM summit2, Unisys es70000, and system from scalemp..

DMI could tell the difference?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/