Re: [PATCH] Change a WARN message in checkpatch

[Andy Whitcroft]

On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
> On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <bhalevy@xxxxxxxxxxx> wrote:
> [...]
> >  How about:
> >  -                               WARN("no space between function name and open parenthesis '('\n" . $herecurr);
> >  +                               WARN("there should be no space between function name and open parenthesis '('\n" . $herecurr);
> 
> I originally suggested:
> +                               WARN("don't put a space between
> function name and open parenthesis '('\n" . $herecurr);
> but I really prefer your version.
> 
> >  The original phrasing can be interpreted like "there is no space between ..." and the correct
> >  interpretation should be "there should be no space between ..."
> 
> Indeed.

As we want the messages to be as short as possible, I am leaning towards
standardising on:

	spaces prohibited <where>
	spaces required <where>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/