Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL

[Evgeniy Polyakov]

Hi Anton.

On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@xxxxxxxxx) wrote:
> On the error condition clk_get() returns ERR_PTR(..), so checking
> for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm
> clock isn't registered.
> 
> This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
> for the return code.
> 
> Signed-off-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>

Both patches look good, thanks Anton.

Andrew, please merge them and add my ack if needed.
Thank you.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/