Re: [patch 2.6.25-rc2-git 1/2] atmel_tc library

[Haavard Skinnemoen]

On Mon, 25 Feb 2008 10:06:44 -0800
David Brownell <david-b@xxxxxxxxxxx> wrote:

> > > > Which reminds me...you were talking about a patch that adds oneshot
> > > > support for the count/compare clocksource and more cleanups, but I
> > > > don't think I've seen it...?
> > > 
> > > I avoid sending non-working patches, and hadn't made time to
> > > work on that issue recently.
> >
> > I was thinking that I could perhaps help you get it working...
> 
> OK, if you want I'll send it.

That would be great. Otherwise I fear your work might be lost...

> > > > I've never really seen the point of indenting those defines at all.
> > > 
> > > Without them, it's harder to discern the logical structure of
> > > all the various bitfields and their contents.
> >
> > I prefer to separate the registers from the bitfields and the other
> > stuff. That way, no indentation is necessary.
> 
> But that way it's no longer clear which symbols apply to which
> registers.  It's not "needed" because that information became
> harder to find ... as in <include/asm-avr32/arch-at32ap/time.h>,
> which ISTR isn't even complete in its bitfield definitions.

Ok, I get your point.

> There's one clear need for tclib:  to hand out timers from the (small)
> pool of hardware entities.  Each one can be used for different purposes
> by different drivers.
> 
> The *current* tclib addresses only that minimal need.
> 
> You're the one who wants to add more to it; I was just pointing out that
> you were being inconsistent.

And I was trying to point out that _you_ were being inconsistent ;-)

> > Of course the driver should be responsible for calling clk_enable() and
> > clk_disable(). Otherwise, power management will be tricky. And since
> > the driver may need to make a decision about which interrupts to
> > request, it might as well call platform_get_irq() directly.
> 
> You're being inconsistent here.  It has to make the same kinds of
> decision about which clocks to enable/disable.  So why should it
> have to platform_get_irq() but not clk_get()?
> 
> > On the other hand, the driver will _always_ need a reference to each
> > clock,
> 
> No; it doesn't need references to clocks for unused TC channels.

Ok. Let's drop the clock references...

> >	and it will always need a pointer through which to access the
> > registers, so the mid-layer might as well do those things.
> 
> True about doing the ioremap.

...and keep the regs pointer, and possibly add the iomem resource.

Ok?

Btw, I'm not saying that you're the one who has to make these changes.
Once we agree, I can send a patch to do the things we agreed on.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/