Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p)

[Rafael J. Wysocki]

On Tuesday, 26 of February 2008, Dave Jones wrote:
> On Tue, Feb 26, 2008 at 10:56:41PM +0100, Pavel Machek wrote:
> 
>  > Seems like pm-utils is just a thin wrapper around s2ram, at least in
>  > version debian ships. It does not seem to have its own whitelist.
> 
> The actual whitelists still live in hal (or specifically hal-data),
> rather than pm-utils.  /usr/share/hal/fdi/information/10freedesktop/20-video-quirk-pm-*
> for example.  This gets passed down to pm-utils by hal.
> 
>  > /usr/lib/pm-utils/functions
>  > 
>  > ... 
>  > 
>  >         if [ -x /usr/sbin/s2ram ]; then
>  >                 if [ -n "$S2RAM_OPTS" ]; then
>  >                         # Trust HAL or the user to pass the correct
>  > options
>  >                         /usr/sbin/s2ram $S2RAM_OPTS
>  >                 elif /usr/sbin/s2ram --test > /dev/null ; then
>  >                         # Trust s2ram's internal whitelist
>  >                         /usr/sbin/s2ram
>  >                 else
>  >                         # Unknown machine
>  >                         echo "This machine is unkown, please try to
>  > find out how to suspend this machine. See s2ram(8)."
>  >                 fi
>  >         else
>  >                 echo -n "mem" > /sys/power/state
>  >         fi
> 
> Seems to be a debian specific change, the variant in Fedora, nor upstream
> pm-utils doesn't have any of that.  Possibly because it's a dumb idea
> to have two separate sources of the same information.
> 
>  > ...so it is ready to use s2ram, but will fall back to
>  > echo. Unfortunately, that will mean no video resume on _many_
>  > machines.
>  > 
>  > To give some numbers: according to s2ram whitelist, we can restore
>  > video on 410 machines. On 74 of them, s2ram is not needed. So
>  > approximately 80% of machines need s2ram (at least in configuration
>  > without X running)....
>  > 
>  > Pretty please, can we get s2ram for Fedora, so that video is restored
>  > there?
>  
> I'm not the gatekeeper of what goes into Fedora userspace, but I'm pretty
> certain the path forward has already been decided.  Running a modern
> Fedora desktop installation without hal just isn't feasible.

Well, pm-utils seems to be a bunch of shell scripts that run some addtional
utilities, such as vbetool, to actually do the quirks.  In s2ram we have all
these additional utilities put together in one package and you need not
use the whiltelist it contains.  You can just very well make pm-utils use
s2ram for doing the low-level work, just build the appropriate command line
for it on the basis of the HAL whitelist.

Frankly, I don't see any conflict between pm-utils and s2ram at a technical
level.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/