Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option

[Jeff Garzik]

Stephen Hemminger wrote:
> > From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
> >
> > Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and
> > fix compilation errors.
> >
> > Cc: Francois Romieu <romieu@xxxxxxxxxxxxx>
> > Cc: Sorbica Shieh <sorbica@xxxxxxxxxxxxx>
> > Cc: Jesse Huang <jesse@xxxxxxxxxxxxx>
> > Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
>
> Please don't do this as a config option. Config options seem like a good idea
> to developers but are difficult for distributions.  Either support jumbo
> frames by default or not at all.

Agreed, but to be more specific...    always compile in jumbo frame 
support.  You don't have to enable it at runtime by default, though.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/