Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues

[Paolo Ciarrocchi]

On 2/26/08, Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> wrote:
>
> On Tuesday 26 February 2008, Borislav Petkov wrote:
> > Signed-off-by: Borislav Petkov <petkovbb@xxxxxxxxx>
> > ---
> > drivers/ide/ide-cd.c | 634
> +++++++++++++++++++++++++------------------------
> > 1 files changed, 323 insertions(+), 311 deletions(-)
>
> With 300 lines changed this is not trivial to review/apply anymore
> (yeah, I sound like a broken record ;-) and since I've already applied
> Paolo's patch from two days ago this one heavily rejects...
>
> Moreover md5sum is different before/after the patch - I tried really hard
> to figure out why (by reverting some changes) but finally I gave up.

is it because of the changes in the include section?
and was the change suggested by checkpatch.pl?

ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/