Re: [PATCH] cpuset: fix return value of cpuset_populate()

[Li Zefan]

Paul Menage wrote:
> On Tue, Feb 26, 2008 at 11:41 PM, Paul Jackson <pj@xxxxxxx> wrote:
>>  - no need to check err == 0
>>  - the last return value of cgroup_add_file() is ignored
>>
>>  Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
> 
> Looks fine from a cleanliness PoV, although since we don't actually do
> anything with an error result from subsys->populate() (a behaviour
> that I sort of inherited from cpusets ...) it won't make a whole lot
> of difference to the code.
> 
> A better change would be to make cpuset_populate() use cgroup_add_files().
> 

Yes, I'm considering this, and I will verify if this will save some bytes
in the object file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/