Re: [patch 2/3] Trace code and documentation

[Andrew Morton]

On Tue, 26 Feb 2008 14:38:48 -0800 "David J. Wilder" <dwilder@xxxxxxxxxx> wrote:

> +	if (strncmp(buf, "start", strlen("start")) == 0) {
> +		ret = trace_start(trace);
> +		if (ret)
> +			return ret;
> +	} else if (strncmp(buf, "stop", strlen("stop")) == 0)
> +		trace_stop(trace);

Does gcc manage to avoid the pointless strlen() calls here?

It's a bit untidy that you can write "startfoo" in there and the kernel
will happily accept it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/