Re: [PATCH] block: fix residual byte count handling

From: Tejun Heo
Date: Thu Feb 28 2008 - 10:46:29 EST


Jens Axboe wrote:
>> This problem was reported and diagnosed by Mike Galbraith.
>
> Tejun, this patch isn't much cleaner at all. It really shows the pain of
> these two seperate, yet related, variables.

Not much cleaner compared to what? I think padding stuff is bound to be
somewhat complex. It's a nasty thing in nature. I think ->extra_len is
better than ->raw_data_len because ->extra_len only needs to be updated
where the dirty jobs are done and extra buffer areas are added. Any
better suggestions?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/