Re: [PATCH 2/3 v3] dma/ia64: update ia64 machvecs

[Michael Ellerman]

On Thu, Feb 28, 2008 at 2:25 PM,  <akepner@xxxxxxx> wrote:
>
>  Change all ia64 machvecs to use the new dma_{un}map_*_attrs()
>  interfaces. Implement the old dma_{un}map_*() interfaces in
>  terms of the corresponding new interfaces. For ia64/sn, make
>  use of one dma attribute, DMA_ATTR_SYNC_ON_WRITE.
>
>  Signed-off-by: Arthur Kepner <akepner@xxxxxxx>
>
>  ---
>
>   arch/ia64/hp/common/hwsw_iommu.c         |   61 ++++++++++++-----------
>   arch/ia64/hp/common/sba_iommu.c          |   64 ++++++++++++++-----------
>   arch/ia64/sn/pci/pci_dma.c               |   79 +++++++++++++++++++++----------
>   include/asm-ia64/dma-mapping.h           |   28 +++++++++-
>   include/asm-ia64/machvec.h               |   52 ++++++++++++--------
>   include/asm-ia64/machvec_hpzx1.h         |   16 +++---
>   include/asm-ia64/machvec_hpzx1_swiotlb.h |   16 +++---
>   include/asm-ia64/machvec_sn2.h           |   16 +++---
>   include/linux/dma-attrs.h                |   55 +++++++++++++++++++++
>   lib/swiotlb.c                            |   50 ++++++++++++++++---
>   10 files changed, 300 insertions(+), 137 deletions(-)


This patch would be better off split into generic and arch portions IMHO.

cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/