Re: 2.6.25 regression/oops on boot (ACPI related?)

[Zhang, Rui]

On Fri, 2008-02-29 at 15:54 +0800, Jonathan McDowell wrote:
> On Fri, Feb 29, 2008 at 01:20:27AM +0800, Zhang, Rui wrote:
> > Please attach the acpidump output using the latest pmtools at :
> > http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/
> > Please attach the result of "cat /proc/acpi/thermal_zone/*/*" as
> well.
> 
> I've attached the output of acpidump. The cat results in this output:
> 
> [noodles@meepok /proc/acpi/thermal_zone/THRM]$ cat *
> 0 - Active; 1 - Passive
> <polling disabled>
> state:                   ok
> temperature:             40 C
> Segmentation fault
> 
> It also causes a general protection fault, which I've attached as
> well.
> 
> This is a stock Debian kernel:
> 
> Linux meepok 2.6.24-1-amd64 #1 SMP Mon Feb 11 13:47:43 UTC 2008 x86_64
> GNU/Linux
> 
> I have a patch from Ming Lin to try out but it'll have to wait until
> tomorrow before I can do so.
> 
We've root caused the problem and Lin Ming's patch should work for you.
Please give it a try. :)

From: Lin Ming <ming.m.lin@xxxxxxxxx>

Fix a memory overflow bug when copying
NULL internal package element object to external.

Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>
Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
---
 drivers/acpi/utilities/utobject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/acpi/utilities/utobject.c
===================================================================
--- linux-2.6.orig/drivers/acpi/utilities/utobject.c
+++ linux-2.6/drivers/acpi/utilities/utobject.c
@@ -432,7 +432,7 @@ acpi_ut_get_simple_object_size(union acp
 	 * element -- which is legal)
 	 */
 	if (!internal_object) {
-		*obj_length = 0;
+		*obj_length = sizeof(union acpi_object);
 		return_ACPI_STATUS(AE_OK);
 	}
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/