Re: [patch 05/21] define page_file_cache() function

[KOSAKI Motohiro]

Hi

> Index: linux-2.6.25-rc2-mm1/mm/swap_state.c
> ===================================================================
> --- linux-2.6.25-rc2-mm1.orig/mm/swap_state.c	2008-02-19 16:23:09.000000000 -0500
> +++ linux-2.6.25-rc2-mm1/mm/swap_state.c	2008-02-27 14:36:57.000000000 -0500
> @@ -82,6 +82,7 @@ int add_to_swap_cache(struct page *page,
>  		if (!error) {
>  			page_cache_get(page);
>  			SetPageSwapCache(page);
> +			SetPageSwapBacked(page);
>  			set_page_private(page, entry.val);
>  			total_swapcache_pages++;
>  			__inc_zone_page_state(page, NR_FILE_PAGES);

hmm,
What do you think NR_FILE_PAGES counted?
SetPageSwapBacked() and increase NR_FILE_PAGES is a bit strange.

but I am worried now.
because if change it, make a incompatibility... ;)


- kosaki


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/