Re: [PATCH 2/9] /drivers/net/8390.c replaced init_module&cleanup_modulewith module_init&module_exit
From: Jon Schindler
Date: Fri Feb 29 2008 - 21:51:06 EST
I've also noticed another issue, it appears that I accidentally gave PATCH 2/9 the wrong subject. Patch 2/9
actually fixes /drivers/net/ac3200.c, while PATCH 1/9 is the one that fixes /drivers/net/8390.c.
What's the easiest way to fix these two patches? Do you want to just back out patches 1 & 2 and
I can send them as part of a different patch set? If I change the subject for PATCH 2/9, it might
be hard for others to follow this thread.
Sorry for the trouble, I'm still getting familiar the mechanics of patch submission.
Jon
Jon Schindler wrote:
> I'm sorry, ns8390_init_module should be ns8390_module_init. I'll resend it in the next reply.
> Andrew Morton wrote:
>> On Thu, 28 Feb 2008 01:30:25 -0600
>> Jon Schindler <jkschind@xxxxxxxxx> wrote:
>>
>>> Replaced init_module and cleanup_module with static functions and module_init/module_exit.
>> I get
>>
>> drivers/net/8390.c: In function '__inittest':
>> drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this function)
>> drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
>> drivers/net/8390.c:60: error: for each function it appears in.)
>> drivers/net/8390.c: At top level:
>> drivers/net/8390.c:60: error: 'init_module' aliased to undefined symbol 'ns8390_init_module'
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/