Re: [UPDATED v3][PATCH 4/7] regulator: framework core

From: Andrew Morton
Date: Sat Mar 08 2008 - 13:32:19 EST


On Sat, 08 Mar 2008 17:24:46 +0000 Liam Girdwood <lg@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> > Should be indented with a tab, not spacespacespacespace
>
> This patch releases the lock in get_device_regulator(), makes
> get_lowest_stable_voltage() non inline and fixes a minor indentation
> issue.

OK, I'll toss it in there, thanks.

It sounds like significant changes will be happening and that we can expect
to see a new patchset?

I assume you noted my s/get_current/read_current/g fix? It'll be needed for
alpha, frv and mn10300. read_current() is a pretty crappy name but I couldn't
think of anything better. It would look nicer if we also did
s/get_voltage/read_voltage/g - your call.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/