Re: [PATCH v2] add time_now_after and other macros which compare with jiffies

From: Dave Young
Date: Sat Mar 08 2008 - 19:54:24 EST


On Sun, Mar 9, 2008 at 12:12 AM, Johannes Weiner <hannes@xxxxxxxxxxxx> wrote:
> Hi Dave, Andrew and all
>
>
> Dave Young <hidave.darkstar@xxxxxxxxx> writes:
>
> > +/* time_now_after(a) return true if now (jiffies) is after a */
> > +#define time_now_after(a) time_after(jiffies, a)
> > +
> > +/* time_now_before(a) return true if now (jiffies) is before a */
> > +#define time_now_before(a) time_before(jiffies, a)
> > +
> > +/* time_now_after_eq(a) return true if now (jiffies) is after or equal to a */
> > +#define time_now_after_eq(a) time_after_eq(jiffies, a)
> > +
> > +/* time_now_before_eq(a) return true if now (jiffies) is before or equal to a */
> > +#define time_now_before_eq(a) time_before_eq(jiffies, a)
>
> How about even more obvious names like time_is_past(), time_is_future(),
> ...?

Thanks for comment.

Then how do we name the _eq version? IMHO, the time_now_* is enough.

>
> Sorry, I missed v1. Should have proposed that earlier.
>
> Hannes
>

Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/