Re: [PATCH] Fix check after use in kernel/exit.c

From: Ingo Molnar
Date: Sun Mar 09 2008 - 07:49:17 EST



* WANG Cong <xiyou.wangcong@xxxxxxxxx> wrote:

> > actually, i unapplied it again because the patch is wrong:
> > mm_release() has side-effects for kernel threads such as the
> > deactivate_mm() [which is important even if the user-mm is NULL]. If
> > the NULL mm dereference can really trigger then it should be avoided
> > within mm_release().
>
> Do you mean that the NULL check should be moved into mm_release()?

yes - we need to run deactivate_mm() for kernel threads.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/