Re: [PATCH] x86: Change x86 to use generic find_next_bit

From: Alexander van Heukelum
Date: Sun Mar 09 2008 - 16:31:55 EST



On Sun, 9 Mar 2008 21:11:52 +0100, "Ingo Molnar" <mingo@xxxxxxx> said:
> * Alexander van Heukelum <heukelum@xxxxxxxxxxxxx> wrote:
> > --- a/lib/find_next_bit.c
> > +++ b/lib/find_next_bit.c
> > @@ -15,6 +15,8 @@
> > #include <asm/byteorder.h>
> >
> > #define BITOP_WORD(nr) ((nr) / BITS_PER_LONG)
> > +#undef find_next_bit
> > +#undef find_next_zero_bit
>
> this bit looks weird - did you need it for testing?

Worse, it's needed to get x86_64 to compile.

They are defined in include/asm-x86/bitops_64.h (which gets
included). They are used to optimize the case where the
bitmap size is known at compile time and not larger than
BITS_PER_LONG. Undeffing them here is the easiest way to get
things to compile, here.

Greetings,
Alexander

--
http://www.fastmail.fm - The way an email service should be

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/