Re: [PATCH v2] add time_now_after and other macros which compare with jiffies

From: Dave Young
Date: Sun Mar 09 2008 - 22:03:59 EST


On Mon, Mar 10, 2008 at 3:01 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, 9 Mar 2008 11:08:08 +0000 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > > Yes, This has a purpose as well. You will find most of the usage of these
> > > macros are just compare some value with jiffies after doing some grep.
> >
> > That is no reason to add more macros that hide how they do it, or make
> > jiffies itself invisible to the grep search or variable usage finding
> > tools (and for tickless that very thing is important)
>
> We could call them time_is_after_jiffies(), time_is_before_jiffies(), etc.
>
> Those names are actually better than time_after_now(), etc.
>
>
Andrew, Hannes, Alan,
thanks for your comment, I have send the new time_is_* patch as v3.

Hannes, It's more like your is_past/is_future but looks better when
along with _eq
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/