Re: [PATCH 2/2] cgroup: switch to proc_create()

From: Li Zefan
Date: Mon Mar 10 2008 - 19:43:50 EST


Paul Menage wrote:
> On Mon, Mar 10, 2008 at 12:30 AM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
>> There is a race between create_proc_entry() and the assignment
>> of file ops. proc_create() is invented to fix it.
>>
>> Signed-off-by: Li Zefan <lizf@xxxxxxxxxxxxxx>
>
> Acked-by: Paul Menage <menage@xxxxxxxxxx>
>
> Doesn't seem to be a serious race since there's nothing in userspace
> at this point to read the file. But replacing four lines with one is
> generally a good thing.
>

Yes I know, it's a slight race in case of modular code, but the aim is
to replace all the use of create_proc_entry() with proc_create(). :)

> Paul
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/