Re: [PATCH REPOST for 2.6.25] Use an own random generator for pageattr-test.c

[Andi Kleen]

On Tue, Mar 11, 2008 at 09:25:21AM +0100, Thomas Gleixner wrote:
> On Tue, 11 Mar 2008, Andi Kleen wrote:
> > Use an own random generator for pageattr-test.c
> > 
> > [Repost. Please ack/nack. This is a bug fix and imho a .25 late merge 
> > candidate because it fixes a subtle bug]
> 
> Care to point out which "subtle bug" is fixed ? 
> 
> You replace a random generator by another to get repeateable
> sequences. The non repeatability of the cpa test patterns is hardly a
> "subtle bug".

The subtle bug(s) are first that it is not repeatable (it really should),
then that it only initializes the CPU where the code first runs
(since srandom32 is per CPU) and later might change CPUs and then that it 
adds totally unnecessary state bits to CPU #0 (or whatever runs first).

-Andii

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/